From 39f804a4340d143c39bda403a25750ac5edbec21 Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Thu, 9 Dec 2021 15:36:54 -0700
Subject: [PATCH] switch gbfile supplemental plane test to nmea. (#786)

---
 reference/testsupplementalplane.csv  |  20 ++++++++++----------
 reference/testsupplementalplane.nmea | Bin 0 -> 724 bytes
 reference/testsupplementalplane.pcx  | Bin 1986 -> 0 bytes
 testo.d/gbfile.test                  |   8 ++------
 4 files changed, 12 insertions(+), 16 deletions(-)
 create mode 100644 reference/testsupplementalplane.nmea
 delete mode 100644 reference/testsupplementalplane.pcx

diff --git a/reference/testsupplementalplane.csv b/reference/testsupplementalplane.csv
index c56f44dc5..12ab1a870 100644
--- a/reference/testsupplementalplane.csv
+++ b/reference/testsupplementalplane.csv
@@ -1,10 +1,10 @@
-No,Latitude,Longitude,Name,Description,Symbol
-1,35.972033,-87.134700,"GCEBB","Mountain Bike Heaven by susy1313","Waypoint"
-2,36.090683,-86.679550,"GC1A37","The 😁 Troll by a182pilot & Family","Waypoint"
-3,35.996267,-86.620117,"GC1C2B","Dive Bomber by JoGPS & family","Waypoint"
-4,36.038483,-86.648617,"GC25A9","FOSTER by JoGPS & Family","Waypoint"
-5,36.112183,-86.741767,"GC2723","Logan Lighthouse by JoGps & Family","Waypoint"
-6,36.064083,-86.790517,"GC2B71","Ganier Cache by Susy1313","Waypoint"
-7,36.087767,-86.809733,"GC309F","Shy's Hill by FireFighterEng33","Waypoint"
-8,36.057500,-86.892000,"GC317A","GittyUp by JoGPS / Warner Parks","Waypoint"
-9,36.082800,-86.867283,"GC317D","Inlighting by JoGPS / Warner Parks","Waypoint"
+No,Latitude,Longitude,Name
+1,35.972033,-87.134700,"GCEBB"
+2,36.090683,-86.679550,"GC1A37😁"
+3,35.996267,-86.620117,"GC1C2B"
+4,36.038483,-86.648617,"GC25A9"
+5,36.112183,-86.741767,"GC2723"
+6,36.064083,-86.790517,"GC2B71"
+7,36.087767,-86.809733,"GC309F"
+8,36.057500,-86.892000,"GC317A"
+9,36.082800,-86.867283,"GC317D"
diff --git a/reference/testsupplementalplane.nmea b/reference/testsupplementalplane.nmea
new file mode 100644
index 0000000000000000000000000000000000000000..2b92e7c85d721263608549846d91e91f136f507f
GIT binary patch
literal 724
zcmZ{iyKciU3;@}+-_gkk3_UG-=#Vr`mLTYsU+>gUNpfUbSau^2@`Er>C(^g;n;hj!
zF07MmBuXYm>3IsoM$Rlprr5Q&tL87PqkPDx?1)ah?B!L~w1Mw4v_$xdHt_Dq7a~?P
zFI(P=ynny^bX1lnOf{T-Ylj6>D|@UR_u0^68O$;B^xQE}7pa?8Jnh7UdCd##za`s2
z%?;jQe(~R#6Zy<O>iyTj06nm~o;Ngjk-Cwd<%M6e^CoJww=-`?-kaZ{!PA)pESCLC
zHhG<Ys(6pS9E>+Mc<QHiZsC_P)AQ;?W<RwpbWr=}8$9jPgx$E}>6{$YdL9qn-gx@I
F+yO#-QI!Ay

literal 0
HcmV?d00001

diff --git a/reference/testsupplementalplane.pcx b/reference/testsupplementalplane.pcx
deleted file mode 100644
index 5cadadddb44b5ada5fc09e9c2cb12b517d5714d8..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1986
zcmb7_+j0^?5Qf{!<tg?`F4V~RU=<hPj73N)OQdp16fqSDDL||6seBx-d=&NjXMiO@
zVp&tWJJa3M{rBHJvwwcKEo4M?ZcXdkz)tPb8c2G~&fM%Js}IaBvFc#gvjku5YS{&{
zD`q)6v5ciG;7PNVj}}%DKDD!9b)-w1@lGOZJ6%Z3j&;$7R&!RT&R(`vyXM^nMbGVR
z68RE|k6A@tWnUMGA}CH0ToLQK4T&_u_sr%tb*qYfV!UNF<-J-DZ{N3Dq$B%|{XO4`
zy>eN+<DFXjyh3w}*9F?1y@naTH^S4@ZrC{?_6UoL+misfSP&ZJbmexOu~x3njR6@d
zixQj$a48G{>l6%Y9*>5@`ERYSiYk*}_<Gl1Q+(FpUzHYz>Vj(?&6S_(8p5!&`l|BE
zN4f;;2JEfdoAn5=5bt8?D_oD<Zh4SK%#M%h`smM{RShfEXN2vN2m>@N`l3OltIk^h
zf~@832Tut;vh<v~E{WxUZ^?@2^c7d7t*(P!`2}E~flmI1pt(m@<$LGQws{Zjn~NV(
z(-qnU)(d87V(E!drQsz@Jb4wWf{UCda*m<8#i*pqAvwXmh^^PfsQUKBA*lR(@k{+Y
zcl|WMw?{F=pR#!X>jd2rjZS3~yi+GzJwjH)R*dcPRbEFg93WE`{`3|Pkk#=nM#Ph<
zbHjYj%Hw*E%%4Y(=krlK8LD+^<t-l1REC&hqI?98>Q^S`Lp-_#Hh0QXD2}s|!CQui
z8&*7uf@4LsJ*=1Rv^??+V{yII&tq~`|8!w!O#PNT>aB%iYnPt~WY5)0wJL((F|sVt
zbq5H+ekZA3Ida*cj*+z-s@rvyYOFr4d&?t=p6q8|i{>5*^>YRWHXQg<=KEPy(m7OT
z3t@~RBIXL2@@~8SjC;AsdJaB)J#Xr$23(HGX!nFEzapJ;$ctxXpO-wlg-AETKB5-U
zmW&m*+5;YU>!W{I$X_Ak4jF<){{Z#)g<IW`MSSW#CjFmwPrW*&3`eDdS_zHrBAu~)
SOdTRkwk+s28sqnWk^KezU;+^U

diff --git a/testo.d/gbfile.test b/testo.d/gbfile.test
index 380f4277f..9f6d69cd7 100644
--- a/testo.d/gbfile.test
+++ b/testo.d/gbfile.test
@@ -8,10 +8,6 @@ compare ${REFERENCE}/track/nmea.gpx ${TMPDIR}/nmea_utf16.gpx
 #   with \r\n line endings
 gpsbabel -i nmea -f ${REFERENCE}/track/nmea_utf16_dos -o gpx -F ${TMPDIR}/nmea_utf16_dos.gpx
 compare ${REFERENCE}/track/nmea.gpx ${TMPDIR}/nmea_utf16_dos.gpx
-# TODO(robertl): Check with tsteven4 if we can find another
-# appropriate test withot PCX
-# Assumes pcx reader is still using gbgetstr.
-# These are handcrafted input files, they may not be legal pcx files.
 #   with a unicode character from the supplemental plane encoded in utf16le.
-## gpsbabel -i pcx -f ${REFERENCE}/testsupplementalplane.pcx -o unicsv -F ${TMPDIR}/testsupplementalplane.csv
-##  compare ${REFERENCE}/testsupplementalplane.csv ${TMPDIR}/testsupplementalplane.csv
+gpsbabel -i nmea -f ${REFERENCE}/testsupplementalplane.nmea -o unicsv -F ${TMPDIR}/testsupplementalplane.csv
+compare ${REFERENCE}/testsupplementalplane.csv ${TMPDIR}/testsupplementalplane.csv
-- 
2.30.2